Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operation to normalise unicode #912

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

matthieuxyz
Copy link
Contributor

@matthieuxyz matthieuxyz commented Nov 25, 2019

See #872

I made a mistake while signing the CLA. My email should be "m[at]tthieu.xyz" instead of "m[at]tthieu". I don't know how to fix that...

@n1474335 n1474335 merged commit a6fa062 into gchq:master Dec 20, 2019
} else if (normalForm === "NFKD") {
return unorm.nfkd(input);
} else if (normalForm === "NFKC") {
return unorm.nfc(input);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be

-return unorm.nfc(input);
+return unorm.nfkc(input);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I should share my pull requests on twitter more often. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants